fix(expect,testing,internal): throw if expect.hasAssertion and expect.assertions are not checked
#6646
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6646 +/- ##
==========================================
+ Coverage 94.75% 94.81% +0.06%
==========================================
Files 584 574 -10
Lines 46563 46439 -124
Branches 6541 6528 -13
==========================================
- Hits 44120 44032 -88
+ Misses 2400 2364 -36
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for the PR! This looks like a nice fix, but I left some comments about code organization. |
|
@kt3k I've rewritten this PR to modify as little of the behavior as possible. Note that |
Thanks for working on this! |
| const { stderr } = await command.output(); | ||
| const errorMessage = stripAnsiCode(new TextDecoder().decode(stderr)); | ||
| // TODO(WWRS): Test for the expected message when Deno displays it instead of "Uncaught null" | ||
| assertStringIncludes(errorMessage, "error: Uncaught"); |
There was a problem hiding this comment.
Is this supposed to be the message generated in unload handler?
There was a problem hiding this comment.
Yes, I think this is an upstream issue, which I've opened: denoland/deno#29087
kt3k
changed the title
expect.hasAssertion and expect.assertions are not checkedexpect.hasAssertion and expect.assertions are not checked
fixes #6518
fixes #6540
Renamed AssertionState to AssertionCounterMoved AssertionCounter fromstd/internaltostd/expect: It's really more of anexpectfeature than aninternalfeatureThis means thatstd/testingnow depends onstd/expectRemovedAssertionCounter.#state.assertionTriggeredto avoid desynchronizing fromassertionTriggeredCountCollected the validation error behavior inAssertionCounterrather than duplicating it intestingAssertionStateis reset after validation: fixesexpect.hasAssertionandexpect.assertionspollute other assertions tests #6540globalThisisunloaded to ensure allAssertionStates are properly validated and reset: fixesexpect.hasAssertionandexpect.assertionssilently pass outside bdd tests #6518